[ExecuTorch][WebGPU] aten.index.Tensor test suite (export + native golden)#20465
Merged
JulianCloudNTH merged 5 commits intoJun 27, 2026
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20465
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 120 PendingAs of commit ac4dc89 with merge base 200f64a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 23, 2026
Merged
Merged
This PR needs a
|
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 25, 2026
…lden) Pull Request resolved: #20465 Adds the test suite for the aten.index.Tensor op (stacked on the op diff): - test/ops/index/test_index.py: exports a module computing x[idx] through VulkanPartitioner for four configs (reorder/repeat indices over distinct self values, so a wrong-gather is visible), asserts a VulkanBackend delegate with index.Tensor absorbed (not a CPU fallback), and writes per-config .pte + .self/.idx/.golden.bin. - test/native/test_index.cpp: a standalone Dawn binary that loads each .pte, feeds self (fp32) + index (int64 at the program boundary, narrowed to the int32 buffer) and compares the gather against the torch golden at 1e-3, with a single-output shape guard. - Wired into CMake (webgpu_index_test), test/TARGETS (python_unittest test_index), and the Dawn native CI script. ghstack-source-id: 397026576 @exported-using-ghexport Differential Revision: [D109479000](https://our.internmc.facebook.com/intern/diff/D109479000/)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 26, 2026
…work) (#20395) Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #20465 * #20464 * #20463 * #20435 * #20399 * #20398 * #20397 * #20396 * __->__ #20395 * #20394 * #20393 * #20392 * #20391 * #20390 * #20363 * #20362 * #20361 * #20360 * #20359 Registers `aten.slice_copy.Tensor` in the `cases.py` op-test framework: a `_slice_suite` of 4 configs (leading-dim slice `[:,1:5]`, last-dim slice `[...,1:3]`, step-2 `[:,0:8:2]`, negative-end `[:,1:-1]`) that `generate_op_tests` exports via `VulkanPartitioner` and compares to a torch golden on Dawn. Also adds `test/ops/slice/test_slice.py` (`SliceModule` + `CONFIGS` + export-delegation/eager smoke test) and the `aten.slice_copy.Tensor` partitioner-allowlist entry in `tester.py`. @exported-using-ghexport Differential Revision: [D108793151](https://our.internmc.facebook.com/intern/diff/D108793151/) Differential Revision: [D108793151](https://our.internmc.facebook.com/intern/diff/D108793151)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 26, 2026
…ermute_copy.default) (#20396) Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #20465 * #20464 * #20463 * #20435 * #20399 * #20398 * #20397 * __->__ #20396 * #20395 * #20394 * #20393 * #20392 * #20391 * #20390 * #20363 * #20362 * #20361 * #20360 * #20359 Adds `aten.permute_copy.default` (a coordinate-reorder gather) to the WebGPU delegate, and the `IntList` graph value type it needs to read its `dims` argument. Composition: - `runtime/WebGPUGraph.{h,cpp}` — adds `ValueType::IntList` backed by `std::vector<std::vector<int64_t>> int_lists_` + `get_int_list(int)`; `build()` deserializes `vkgraph::GraphTypes::IntList` via `value_as_IntList()->items()` (int64, matching the FlatBuffer `[long]`); mirrors the existing scalar value plumbing. - `runtime/ops/permute/Permute.cpp` — reads the permutation via `get_int_list`, normalizes negative dims, validates it is a permutation of `[0, ndim)`, builds two `TensorMeta` UBOs + a `PermuteParams{perm: vec4<u32>}` uniform, guards fp32 + rank≤4, dispatches over `compute_1d_workgroup_count(out.numel)` with `override wg_size`; releases all uniforms after the bind group. - `runtime/ops/permute/permute.wgsl` — delinearizes the output index over the contiguous output strides, reads `input` at `in.strides[perm[d]]` per dim (mirrors Vulkan `permute_buffer.glsl`). - Registers both `aten.permute_copy.default` and `aten.permute.default` to the same handler. @exported-using-ghexport Differential Revision: [D108793162](https://our.internmc.facebook.com/intern/diff/D108793162/) Differential Revision: [D108793162](https://our.internmc.facebook.com/intern/diff/D108793162)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 26, 2026
…mework) (#20397) Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #20465 * #20464 * #20463 * #20435 * #20399 * #20398 * __->__ #20397 * #20396 * #20395 * #20394 * #20393 * #20392 * #20391 * #20390 * #20363 * #20362 * #20361 * #20360 * #20359 Registers `aten.permute_copy.default` in the `cases.py` op-test framework: a `_permute_suite` of 4 configs (3D rotation, 4D middle-dim transpose, 2D transpose, full 4D shuffle) that `generate_op_tests` exports via `VulkanPartitioner` and compares to a torch golden on Dawn. Also adds `test/ops/permute/test_permute.py` (`PermuteModule` + `CONFIGS` + `_op_delegated` smoke test) and the `aten.permute_copy.default` partitioner-allowlist entry in `tester.py`. @exported-using-ghexport Differential Revision: [D108793156](https://our.internmc.facebook.com/intern/diff/D108793156/) Differential Revision: [D108793156](https://our.internmc.facebook.com/intern/diff/D108793156)
psiddh
approved these changes
Jun 26, 2026
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 26, 2026
…lden) Pull Request resolved: #20465 Adds the test suite for the aten.index.Tensor op (stacked on the op diff): - test/ops/index/test_index.py: exports a module computing x[idx] through VulkanPartitioner for four configs (reorder/repeat indices over distinct self values, so a wrong-gather is visible), asserts a VulkanBackend delegate with index.Tensor absorbed (not a CPU fallback), and writes per-config .pte + .self/.idx/.golden.bin. - test/native/test_index.cpp: a standalone Dawn binary that loads each .pte, feeds self (fp32) + index (int64 at the program boundary, narrowed to the int32 buffer) and compares the gather against the torch golden at 1e-3, with a single-output shape guard. - Wired into CMake (webgpu_index_test), test/TARGETS (python_unittest test_index), and the Dawn native CI script. ghstack-source-id: 397534717 @exported-using-ghexport Differential Revision: [D109479000](https://our.internmc.facebook.com/intern/diff/D109479000/)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
…lden) Pull Request resolved: #20465 Adds the test suite for the aten.index.Tensor op (stacked on the op diff): - test/ops/index/test_index.py: exports a module computing x[idx] through VulkanPartitioner for four configs (reorder/repeat indices over distinct self values, so a wrong-gather is visible), asserts a VulkanBackend delegate with index.Tensor absorbed (not a CPU fallback), and writes per-config .pte + .self/.idx/.golden.bin. - test/native/test_index.cpp: a standalone Dawn binary that loads each .pte, feeds self (fp32) + index (int64 at the program boundary, narrowed to the int32 buffer) and compares the gather against the torch golden at 1e-3, with a single-output shape guard. - Wired into CMake (webgpu_index_test), test/TARGETS (python_unittest test_index), and the Dawn native CI script. ghstack-source-id: 397756255 @exported-using-ghexport @diff-train-skip-merge Differential Revision: [D109479000](https://our.internmc.facebook.com/intern/diff/D109479000/)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
…lden) Pull Request resolved: #20465 Adds the test suite for the aten.index.Tensor op (stacked on the op diff): - test/ops/index/test_index.py: exports a module computing x[idx] through VulkanPartitioner for four configs (reorder/repeat indices over distinct self values, so a wrong-gather is visible), asserts a VulkanBackend delegate with index.Tensor absorbed (not a CPU fallback), and writes per-config .pte + .self/.idx/.golden.bin. - test/native/test_index.cpp: a standalone Dawn binary that loads each .pte, feeds self (fp32) + index (int64 at the program boundary, narrowed to the int32 buffer) and compares the gather against the torch golden at 1e-3, with a single-output shape guard. - Wired into CMake (webgpu_index_test), test/TARGETS (python_unittest test_index), and the Dawn native CI script. ghstack-source-id: 397763261 @exported-using-ghexport @diff-train-skip-merge Differential Revision: [D109479000](https://our.internmc.facebook.com/intern/diff/D109479000/)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
…efault) (#20398) Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #20465 * #20464 * #20463 * #20435 * #20399 * __->__ #20398 Adds `aten.cat.default` to the WebGPU delegate as an index-math scatter, and the `ValueList` graph value type it needs to read its tensor-list argument. Composition (one dispatch per input): - `runtime/WebGPUGraph.{h,cpp}` — adds `ValueType::ValueList` backed by `std::vector<std::vector<int>> value_lists_` + `get_value_list(int)`; `build()` deserializes `vkgraph::GraphTypes::ValueList` via `value_as_ValueList()->items()`; mirrors the existing scalar value plumbing. - `runtime/ops/cat/Cat.cpp` — reads the input-tensor list via `get_value_list`, reads the static `Int` dim, validates each input rank + non-concat dims against the output; builds one shared `out_meta` `TensorMeta` uniform + a shared bind-group/pipeline layout; per input builds a fresh pipeline + bind group with `in_meta` + `CatParams{concat_dim, off_k}`, dispatches over `compute_1d_workgroup_count(in.numel)`; releases per-input uniforms after each bind group, the shared `out_meta` after the loop. - `runtime/ops/cat/cat.wgsl` — delinearizes the input index over the input strides, shifts the concat-dim coordinate by the host-computed `off_k` (running sum of prior input sizes), relinearizes over the output strides to scatter `output[out] = input[in]`. - The N disjoint-slab writes share one output buffer across separate dispatches and rely on the existing per-pass `execute()` ordering. @exported-using-ghexport Differential Revision: [D108793165](https://our.internmc.facebook.com/intern/diff/D108793165/) Differential Revision: [D108793165](https://our.internmc.facebook.com/intern/diff/D108793165)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
…20399) Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #20465 * #20464 * #20463 * #20435 * __->__ #20399 * #20398 Registers `aten.cat.default` in the `cases.py` op-test framework: a `_cat_suite` of 4 configs (3 inputs along dim 0, 2 inputs along dim 1, 3 inputs along dim 2, uneven split along dim 1) that `generate_op_tests` exports via `VulkanPartitioner` and compares to a torch golden on Dawn. Also adds `test/ops/cat/test_cat.py` (`CatModule` + `CONFIGS` + `_op_delegated` smoke test, with distinct per-input value ranges to catch cross-slab contamination) and the `aten.cat.default` partitioner-allowlist entry in `tester.py`. @exported-using-ghexport Differential Revision: [D108793163](https://our.internmc.facebook.com/intern/diff/D108793163/) Differential Revision: [D108793163](https://our.internmc.facebook.com/intern/diff/D108793163)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
…>.py (#20435) Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #20465 * #20464 * #20463 * __->__ #20435 * #20399 * #20398 Pure test-file relocation: moves the already-landed ops' tests from nested `test/ops/<op>/test_<op>.py` to flat `test/ops/test_<op>.py`, matching the ExecuTorch convention (XNNPACK uses flat `test/ops/test_<op>.py`; Vulkan uses flat `test/test_*.py`) and completing the flatten applied to the new ops in the stack below. Drops the per-op `__init__.py`; the parent `test/ops/__init__.py` is kept. Ops: `add`, `rms_norm`, `sdpa` (`test_sdpa` + `test_update_cache`), `dispatch_order`, `quantized_linear`, `embedding_q4gsw`, `rope`, `prepack`. No behavior change — the test modules and their export/golden functions are unchanged; only their path moves. Every reference to the old paths is updated: the `cases.py` op-test imports (`add`, `rms_norm`), `test/TARGETS` (`test_add` srcs), `test/ops/test_dispatch_order.py`'s internal `rms_norm` import, and the build/CI scripts that import the per-op export functions (`test/test_build_webgpu.sh`, `scripts/test_webgpu_native_ci.sh`). Nothing required the per-op subdirectory: the codegen framework imports only `cases.py`, the one buck target uses a literal path, and the native-golden scripts import the modules by path — each resolves identically at the flat path. @exported-using-ghexport Differential Revision: [D109349894](https://our.internmc.facebook.com/intern/diff/D109349894/) Differential Revision: [D109349894](https://our.internmc.facebook.com/intern/diff/D109349894)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #20465 * #20464 * __->__ #20463 * #20435 * #20399 * #20398 `aten.clone.default` is a pure flat copy on the buffer-only WebGPU backend, identical to `view_copy`: `clone_impl` reuses the existing `add_flat_copy` helper (`output[i] = input[i]`) and registers a handler under `aten.clone.default`. No new shader, generated WGSL header, or CMake source — it shares the `view_copy` flat-copy compute pipeline. Required for end-to-end Llama 3.2 1B (4-bit, KV cache): the exported model serializes 2 `aten.clone.default` ops into its runtime operator chain (the RoPE-frequency clones reused across all 16 transformer layers), so without a handler the partition graph-breaks at those nodes. Mirrors the Vulkan delegate, which registers the same op and routes a buffer clone to a flat view-copy. @exported-using-ghexport Differential Revision: [D109477717](https://our.internmc.facebook.com/intern/diff/D109477717/) Differential Revision: [D109477717](https://our.internmc.facebook.com/intern/diff/D109477717)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #20465 * __->__ #20464 * #20463 * #20435 * #20399 * #20398 Adds the WebGPU delegate handler for aten.index.Tensor, the 1D-self advanced-index gather out[i] = self[index[i]] (output shape == index shape). This is the form the VulkanPartitioner delegates -- it requires a 1D self and exactly one non-None index (op_registry.py); 2D mask/freqs gathers stay on CPU. It mirrors the Vulkan delegate's index_tensor op (IndexTensor.cpp + index_tensor_buffer.glsl) as a single compute dispatch over the output elements, each reading the int32 index and gathering the corresponding fp32 self element. The op is composed as: - index.wgsl: one workgroup-strided pass, out[i] = self[u32(index[i])], guarded by a numel bound; buffer-only, fp32 self/out, int32 index, 1D dispatch via the shared WebGPUUtils helpers (clamp workgroup size + 1D count). - Index.cpp: validates the args (self/out tensors; indices ValueList with exactly one index tensor; fp32 self/out; int32 index; out numel == index numel), failing loud on any violation, then records the dispatch. row_width is dropped (always 1 for 1D self). @exported-using-ghexport Differential Revision: [D109478967](https://our.internmc.facebook.com/intern/diff/D109478967/) Differential Revision: [D109478967](https://our.internmc.facebook.com/intern/diff/D109478967)
837a33f
into
gh/JulianCloudNTH/60/base
177 of 179 checks passed
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
…lden) Pull Request resolved: #20465 Adds the test suite for the aten.index.Tensor op (stacked on the op diff): - test/ops/index/test_index.py: exports a module computing x[idx] through VulkanPartitioner for four configs (reorder/repeat indices over distinct self values, so a wrong-gather is visible), asserts a VulkanBackend delegate with index.Tensor absorbed (not a CPU fallback), and writes per-config .pte + .self/.idx/.golden.bin. - test/native/test_index.cpp: a standalone Dawn binary that loads each .pte, feeds self (fp32) + index (int64 at the program boundary, narrowed to the int32 buffer) and compares the gather against the torch golden at 1e-3, with a single-output shape guard. - Wired into CMake (webgpu_index_test), test/TARGETS (python_unittest test_index), and the Dawn native CI script. ghstack-source-id: 397763261 @exported-using-ghexport @diff-train-skip-merge Differential Revision: [D109479000](https://our.internmc.facebook.com/intern/diff/D109479000/)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
…lden) Pull Request resolved: #20465 Adds the test suite for the aten.index.Tensor op (stacked on the op diff): - test/ops/index/test_index.py: exports a module computing x[idx] through VulkanPartitioner for four configs (reorder/repeat indices over distinct self values, so a wrong-gather is visible), asserts a VulkanBackend delegate with index.Tensor absorbed (not a CPU fallback), and writes per-config .pte + .self/.idx/.golden.bin. - test/native/test_index.cpp: a standalone Dawn binary that loads each .pte, feeds self (fp32) + index (int64 at the program boundary, narrowed to the int32 buffer) and compares the gather against the torch golden at 1e-3, with a single-output shape guard. - Wired into CMake (webgpu_index_test), test/TARGETS (python_unittest test_index), and the Dawn native CI script. ghstack-source-id: 397763261 @exported-using-ghexport @diff-train-skip-merge Differential Revision: [D109479000](https://our.internmc.facebook.com/intern/diff/D109479000/)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
…lden) Pull Request resolved: #20465 Adds the test suite for the aten.index.Tensor op (stacked on the op diff): - test/ops/index/test_index.py: exports a module computing x[idx] through VulkanPartitioner for four configs (reorder/repeat indices over distinct self values, so a wrong-gather is visible), asserts a VulkanBackend delegate with index.Tensor absorbed (not a CPU fallback), and writes per-config .pte + .self/.idx/.golden.bin. - test/native/test_index.cpp: a standalone Dawn binary that loads each .pte, feeds self (fp32) + index (int64 at the program boundary, narrowed to the int32 buffer) and compares the gather against the torch golden at 1e-3, with a single-output shape guard. - Wired into CMake (webgpu_index_test), test/TARGETS (python_unittest test_index), and the Dawn native CI script. ghstack-source-id: 397763261 @exported-using-ghexport @diff-train-skip-merge Differential Revision: [D109479000](https://our.internmc.facebook.com/intern/diff/D109479000/)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
…lden) Pull Request resolved: #20465 Adds the test suite for the aten.index.Tensor op (stacked on the op diff): - test/ops/index/test_index.py: exports a module computing x[idx] through VulkanPartitioner for four configs (reorder/repeat indices over distinct self values, so a wrong-gather is visible), asserts a VulkanBackend delegate with index.Tensor absorbed (not a CPU fallback), and writes per-config .pte + .self/.idx/.golden.bin. - test/native/test_index.cpp: a standalone Dawn binary that loads each .pte, feeds self (fp32) + index (int64 at the program boundary, narrowed to the int32 buffer) and compares the gather against the torch golden at 1e-3, with a single-output shape guard. - Wired into CMake (webgpu_index_test), test/TARGETS (python_unittest test_index), and the Dawn native CI script. ghstack-source-id: 397763261 @exported-using-ghexport @diff-train-skip-merge Differential Revision: [D109479000](https://our.internmc.facebook.com/intern/diff/D109479000/)
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 27, 2026
…lden) Pull Request resolved: #20465 Adds the test suite for the aten.index.Tensor op (stacked on the op diff): - test/ops/index/test_index.py: exports a module computing x[idx] through VulkanPartitioner for four configs (reorder/repeat indices over distinct self values, so a wrong-gather is visible), asserts a VulkanBackend delegate with index.Tensor absorbed (not a CPU fallback), and writes per-config .pte + .self/.idx/.golden.bin. - test/native/test_index.cpp: a standalone Dawn binary that loads each .pte, feeds self (fp32) + index (int64 at the program boundary, narrowed to the int32 buffer) and compares the gather against the torch golden at 1e-3, with a single-output shape guard. - Wired into CMake (webgpu_index_test), test/TARGETS (python_unittest test_index), and the Dawn native CI script. ghstack-source-id: 397763261 @exported-using-ghexport @diff-train-skip-merge Differential Revision: [D109479000](https://our.internmc.facebook.com/intern/diff/D109479000/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adds the test suite for the aten.index.Tensor op (stacked on the op diff):
VulkanPartitioner for four configs (reorder/repeat indices over distinct self
values, so a wrong-gather is visible), asserts a VulkanBackend delegate with
index.Tensor absorbed (not a CPU fallback), and writes per-config .pte +
.self/.idx/.golden.bin.
self (fp32) + index (int64 at the program boundary, narrowed to the int32 buffer)
and compares the gather against the torch golden at 1e-3, with a single-output
shape guard.
and the Dawn native CI script.
@exported-using-ghexport
Differential Revision: D109479000
Differential Revision: D109479000